[PATCH] D39820: [cfi-verify] Validate there are no spills between CFI-check and instruction execution.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 13:28:25 PST 2017


hctim updated this revision to Diff 122718.
hctim added a comment.

Updated clobber checking to use `hasDefOfPhysReg` rather than the implicit counterpart. This change now includes a modification to make `MCInstrDesc::hasDefOfPhysReg` public on pcc's reccomendation.

Also added an explicit unit test that sets `rax` then jumps to it, rather than relying on a REX prefix byte to target the register, as this was still considered an 'implicitly' changed register.


https://reviews.llvm.org/D39820

Files:
  include/llvm/MC/MCInstrDesc.h
  tools/llvm-cfi-verify/lib/FileAnalysis.cpp
  tools/llvm-cfi-verify/lib/FileAnalysis.h
  tools/llvm-cfi-verify/lib/GraphBuilder.cpp
  tools/llvm-cfi-verify/lib/GraphBuilder.h
  unittests/tools/llvm-cfi-verify/FileAnalysis.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39820.122718.patch
Type: text/x-patch
Size: 8701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171113/bcdacbd1/attachment.bin>


More information about the llvm-commits mailing list