[PATCH] D39819: [cfi-verify] Add DOT graph printing for GraphResult objects.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/tools/llvm-cfi-verify/X86/dot-printing.s:12
+# Note: We check this behaviour using regexes so that the output doesn't depend
+# on the order of iteration of the classes used to implement the graphs. The
+# order of output in DOT format does not change the meaning of the graph.
----------------
hctim wrote:
> pcc wrote:
> > Can you make the code deterministic by sorting the keys of `IntermediateNodes` before enumerating them? Then you can be more explicit in this test.
> I'd be very worried about the perf implications of this - with `--print_graphs` every single CFG would be sorted, `O(n . log n)` over 100,000 elements with ~10 elements each would be extremely expensive.
This is a debugging feature, so the perf isn't too important. I wouldn't realistically expect people to render such large graphs, anyway.


https://reviews.llvm.org/D39819