[PATCH] D39894: [AArch64][SVE] Asm: Report SVE parsing diagnostics only once

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 12:34:28 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D39894#923025, @sdesmalen wrote:

> tryParseSVERegister() will also handle Predicates when we extend matchRegisterNameAlias with SVE predicates in a later patch, similar to how we did it for data vectors and so there is no need for having the 'DataVector' part in the name.


Ah, excellent! Normally, such a change would need to be done in a separate patch, but it should be fine for such a small and preparatory patch.

I'll review the changes soon. Sorry, I'm at SC17 now.


https://reviews.llvm.org/D39894





More information about the llvm-commits mailing list