[PATCH] D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 10:16:23 PST 2017


dtemirbulatov updated this revision to Diff 122683.
dtemirbulatov added a comment.

Fixed two issues associated with last build failures.

1. llvm IR standard violation with second parameter always as integer 32-bit for Shl, LShr, AShr, but according to https://llvm.org/docs/LangRef.html#lshr-instruction both arguments toof those instructions must be the same type. I have a testcase for the issue, but I think it is not required, please comment if you think otherwise.
2. allow SystemZ SLP tests only when SystemZ is supported in a build.

This time I bootstraped the compiler on x86 with all changes without any failures.


https://reviews.llvm.org/D28907

Files:
  lib/Transforms/Vectorize/SLPVectorizer.cpp
  test/Transforms/SLPVectorizer/SystemZ/lit.local.cfg
  test/Transforms/SLPVectorizer/SystemZ/pr34619.ll
  test/Transforms/SLPVectorizer/X86/vect_copyable_in_binops.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28907.122683.patch
Type: text/x-patch
Size: 67088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171113/3e811b08/attachment-0001.bin>


More information about the llvm-commits mailing list