[PATCH] D39959: [ELF] - Allow merging of strings sections for -relocatable output.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 08:51:28 PST 2017


jhenderson added a comment.

Given that the issue with not combining sections was purely restricted to .debug_str, which only ever has an entsize of 1, would it not make more sense to not combine the InputSections for different entsize values?

I'm wary about removing the SHF_MERGE flag, because I'm pretty sure mergeable sections of different sizes are not that rare, although they do not typically have the same name, so maybe it's okay.


https://reviews.llvm.org/D39959





More information about the llvm-commits mailing list