[compiler-rt] r318002 - [sanitizer] Simplify stack check in accert.cc

[Bill Seurer via llvm-commits]

This revision broke that test case on powerpc64.

http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/7917

FAIL: SanitizerCommon-asan-powerpc64le-Linux::assert.cc
FAIL: SanitizerCommon-lsan-powerpc64le-Linux::assert.cc
FAIL: SanitizerCommon-msan-powerpc64le-Linux::assert.cc
FAIL: SanitizerCommon-ubsan-powerpc64le-Linux::assert.cc



******************** TEST 'SanitizerCommon-asan-powerpc64le-Linux :: 
Linux/assert.cc' FAILED ********************
Script:
--
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/stage1/./bin/clang 
--driver-mode=g++ -gline-tables-only -fsanitize=address -m64 
-fno-function-sections 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/assert.cc 
-o 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/stage1/projects/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/assert.cc.tmp
not --crash 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/stage1/projects/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/assert.cc.tmp 
2>&1 | FileCheck --check-prefix=CHECK0 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/assert.cc
env ASAN_OPTIONS=handle_abort=0 not --crash 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/stage1/projects/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/assert.cc.tmp 
2>&1 | FileCheck --check-prefix=CHECK0 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/assert.cc
env ASAN_OPTIONS=handle_abort=1 not 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/stage1/projects/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/assert.cc.tmp 
2>&1 | FileCheck --check-prefix=CHECK1 
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/assert.cc
--
Exit Code: 1

Command Output (stderr):
--
/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/assert.cc:28:12: 
error: expected string not found in input
// CHECK1: {{#[0-9]+.* main .*assert\.cc}}:[[@LINE-5]]
            ^
<stdin>:4:40: note: scanning from here
==11286==ERROR: AddressSanitizer: ABRT on unknown address 0x03e900002c16 
(pc 0x3fff82a3e3a4 bp 0x3fffd8ccd390 sp 0x3fffd8ccd2f0 T0)
                                        ^
<stdin>:4:40: note: with expression "@LINE-5" equal to "23"
==11286==ERROR: AddressSanitizer: ABRT on unknown address 0x03e900002c16 
(pc 0x3fff82a3e3a4 bp 0x3fffd8ccd390 sp 0x3fffd8ccd2f0 T0)
                                        ^
<stdin>:8:74: note: possible intended match here
SUMMARY: AddressSanitizer: ABRT 
(/lib/powerpc64le-linux-gnu/libc.so.6+0x3e3a0) in gsignal
                                                                          ^

--


On 11/12/2017 03:15 PM, Vitaly Buka via llvm-commits wrote:
> Author: vitalybuka
> Date: Sun Nov 12 13:15:19 2017
> New Revision: 318002
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=318002&view=rev
> Log:
> [sanitizer] Simplify stack check in accert.cc
> Somehow on arm bots stack does not include main.
> 
> Modified:
>      compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/assert.cc
> 
> Modified: compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/assert.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/assert.cc?rev=318002&r1=318001&r2=318002&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/assert.cc (original)
> +++ compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/assert.cc Sun Nov 12 13:15:19 2017
> @@ -4,7 +4,6 @@
>   // RUN: %clangxx %s -o %t
>   // RUN:                              not --crash %run %t 2>&1 | FileCheck --check-prefix=CHECK0 %s
>   // RUN: %env_tool_opts=handle_abort=0 not --crash %run %t 2>&1 | FileCheck --check-prefix=CHECK0 %s
> -// RUN: %env_tool_opts=handle_abort=1 not         %run %t
>   // RUN: %env_tool_opts=handle_abort=1 not         %run %t 2>&1 | FileCheck --check-prefix=CHECK1 %s
>   // clang-format on
>   
> @@ -26,6 +25,7 @@ int main(int argc, char **argv) {
>   
>   // CHECK0-NOT: Sanitizer:DEADLYSIGNAL
>   // CHECK1: ERROR: {{.*}}Sanitizer: ABRT
> -// CHECK1: {{#[0-9]+.* main .*assert\.cc}}:[[@LINE-5]]
> +// CHECK1-NEXT: {{ #0 }}
> +// CHECK1-NEXT: {{ #1 }}
>   // CHECK1: DEATH CALLBACK
>   // CHECK0-NOT: Sanitizer
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 


-- 

-Bill Seurer