[PATCH] D39919: [llvm-objcopy] Add --strip-debug

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor nit.

I noticed that we are being inconsistent with the capitalization of the help text for the different options. At some point, could you make a change to capitalize the first character of help text for options that aren't already in this state, to make it consistent with other LLVM tools, please.



================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:85
+static cl::opt<bool> StripDebug("strip-debug",
+                                cl::desc("Removes all debug information"));
 static cl::opt<bool> StripSections("strip-sections",
----------------
Removes -> Remove (for consistency with other options).


Repository:
  rL LLVM

https://reviews.llvm.org/D39919