[PATCH] D39835: [GVN PRE] Clear nsw/nuw for original values in LoadPRE

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 12 19:24:39 PST 2017


skatkov added a comment.

What is the resolution of the review? Should I land it?



================
Comment at: lib/Transforms/Scalar/GVN.cpp:773
+      if (auto *I = dyn_cast<Instruction>(V))
+        if (isa<OverflowingBinaryOperator>(I)) {
+          I->setHasNoSignedWrap(false);
----------------
Side question, will usage of I->dropPoisonGeneratingFlags() better here?


https://reviews.llvm.org/D39835





More information about the llvm-commits mailing list