[PATCH] D39931: AMDGPU: Don't try to enable fp64 denormals on <SI

Jan Vesely via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 11 15:25:18 PST 2017


jvesely added a comment.

In https://reviews.llvm.org/D39931#922738, @arsenm wrote:

> Fp64 denormals are always supported


This makes no sense, it was clearly disabled on line 70 before for <= NI. This change just makes sure it does not enable fp64 en masse on all asics in the process.

FP64 denormals are not supported if fp64 is not supported.
Moreover, table 8.1 in R900 ISA docs show that adding a denormal has no effect if the other operand is finite, and adding 2 denormals is 0.
The same for EG in table 9.1 (R800 ISA docs).


Repository:
  rL LLVM

https://reviews.llvm.org/D39931





More information about the llvm-commits mailing list