[PATCH] D39941: Set hasSideEffects=0 for TargetOpcode::{CFI_INSTRUCTION, EH_LABEL, GC_LABEL, ANNOTATION_LABEL}
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 11 09:37:24 PST 2017
asb created this revision.
https://reviews.llvm.org/D37065 (committed as https://reviews.llvm.org/rL317674) explicitly set hasSideEffects for all TargetOpcode::* instructions where it was inferred previously. This is a follow-up to that patch, setting hasSideEffects=0 for CFI_INSTRUCTION, EH_LABEL, GC_LABEL and ANNOTATION_LABEL. All LLVM tests pass after this change.
https://reviews.llvm.org/D39941
Files:
include/llvm/Target/Target.td
Index: include/llvm/Target/Target.td
===================================================================
--- include/llvm/Target/Target.td
+++ include/llvm/Target/Target.td
@@ -906,31 +906,31 @@
let InOperandList = (ins i32imm:$id);
let AsmString = "";
let hasCtrlDep = 1;
- let hasSideEffects = 1;
+ let hasSideEffects = 0;
let isNotDuplicable = 1;
}
def EH_LABEL : Instruction {
let OutOperandList = (outs);
let InOperandList = (ins i32imm:$id);
let AsmString = "";
let hasCtrlDep = 1;
- let hasSideEffects = 1;
+ let hasSideEffects = 0;
let isNotDuplicable = 1;
}
def GC_LABEL : Instruction {
let OutOperandList = (outs);
let InOperandList = (ins i32imm:$id);
let AsmString = "";
let hasCtrlDep = 1;
- let hasSideEffects = 1;
+ let hasSideEffects = 0;
let isNotDuplicable = 1;
}
def ANNOTATION_LABEL : Instruction {
let OutOperandList = (outs);
let InOperandList = (ins i32imm:$id);
let AsmString = "";
let hasCtrlDep = 1;
- let hasSideEffects = 1;
+ let hasSideEffects = 0;
let isNotDuplicable = 1;
}
def KILL : Instruction {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39941.122587.patch
Type: text/x-patch
Size: 1103 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171111/4c1d7af5/attachment.bin>
More information about the llvm-commits
mailing list