[PATCH] D39712: [ARM] Add an alias for psr and psr_nzcvq

Fri Nov 10 23:08:06 PST 2017

rengolin added a comment.

I'v looked everywhere and "psr" is not even pre-UAL. Please, fix the user code instead.

In https://reviews.llvm.org/D39712#922648, @xiangzhai wrote:

> Provided a diagnostic indicating that "xpsr" should be used instead of "psr":

This is an arbitrary choice that I'm not ready to approve.

> I am not familiar with the History https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=62b3e31101ef2dfb96ee4652d5145e722b335e31

This is a commit from more than 10 years ago in GCC. There is no evidence where the original author got the "psr" from and no documents supporting this choice.

As I said, we will most certainly not emulate GCC bug-for-bug.

The proper fix is to string-replace "psr" for "xpsr" in the user's code, which honestly, can't be that widely used, or we would have seen it by now.

cheers,
--renato

Repository:
  rL LLVM

https://reviews.llvm.org/D39712