[llvm] r317967 - [X86] Remove the default for one of the arguments to some tablegen multiclasses. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 18:26:02 PST 2017


Author: ctopper
Date: Fri Nov 10 18:26:02 2017
New Revision: 317967

URL: http://llvm.org/viewvc/llvm-project?rev=317967&view=rev
Log:
[X86] Remove the default for one of the arguments to some tablegen multiclasses. NFC

No one ever uses this default and probably shouldn't since it sets the execution domain to generic.

Modified:
    llvm/trunk/lib/Target/X86/X86InstrSSE.td

Modified: llvm/trunk/lib/Target/X86/X86InstrSSE.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=317967&r1=317966&r2=317967&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86InstrSSE.td (original)
+++ llvm/trunk/lib/Target/X86/X86InstrSSE.td Fri Nov 10 18:26:02 2017
@@ -386,8 +386,7 @@ let isReMaterializable = 1, isAsCheapAsA
 
 multiclass sse12_move_rr<SDNode OpNode, ValueType vt,
                          X86MemOperand x86memop, string base_opc,
-                         string asm_opr, Domain d = GenericDomain,
-                         string Name> {
+                         string asm_opr, Domain d, string Name> {
   let isCommutable = 1 in
   def rr : SI<0x10, MRMSrcReg, (outs VR128:$dst),
               (ins VR128:$src1, VR128:$src2),
@@ -406,7 +405,7 @@ multiclass sse12_move_rr<SDNode OpNode,
 
 multiclass sse12_move<RegisterClass RC, SDNode OpNode, ValueType vt,
                       X86MemOperand x86memop, string OpcodeStr,
-                      Domain d = GenericDomain, string Name> {
+                      Domain d, string Name> {
   // AVX
   defm V#NAME : sse12_move_rr<OpNode, vt, x86memop, OpcodeStr,
                               "\t{$src2, $src1, $dst|$dst, $src1, $src2}", d,
@@ -431,8 +430,7 @@ multiclass sse12_move<RegisterClass RC,
 
 // Loading from memory automatically zeroing upper bits.
 multiclass sse12_move_rm<RegisterClass RC, X86MemOperand x86memop,
-                         PatFrag mem_pat, string OpcodeStr,
-                         Domain d = GenericDomain> {
+                         PatFrag mem_pat, string OpcodeStr, Domain d> {
   def V#NAME#rm : SI<0x10, MRMSrcMem, (outs RC:$dst), (ins x86memop:$src),
                      !strconcat(OpcodeStr, "\t{$src, $dst|$dst, $src}"),
                      [(set RC:$dst, (mem_pat addr:$src))],




More information about the llvm-commits mailing list