[PATCH] D39469: [asan] Add CMake hook to override shadow scale in compiler_rt

[Walter Lee via Phabricator via llvm-commits]

waltl marked an inline comment as done.
waltl added inline comments.


================
Comment at: compiler-rt/test/lit.common.configured.in:28
 set_default("emulator", "@COMPILER_RT_EMULATOR@")
+set_default("asan_shadow_scale", "@COMPILER_RT_ASAN_SHADOW_SCALE@")
 set_default("ios", False)
----------------
vitalybuka wrote:
> waltl wrote:
> > vitalybuka wrote:
> > > can you just just use target_cflags and COMPILER_RT_TEST_COMPILER_CFLAGS
> > Maybe?  Currently COMPILER_RT_TEST_COMPILER_CFLAGS doesn't get propagated to target_cflags because individual sanitizers have their own definitions of target_cflags that supercede it.  Is this intended?  If the right thing to do is to append the target_cflags together I can do that and it'd better serve our purpose here.
> > 
> They append content of COMPILER_RT_TEST_COMPILER_CFLAGS, it's in  get_test_cc_for_arch implementation
Sorry if I'm missing something, but it looks to me that in get_test_cc_for_arch, COMPILER_RT_TEST_COMPILER_CFLAGS is only used for ANDROID, arm, and aarch64.  For others, the target CFLAGS comes from TARGET_${arch}_CFLAGS which is constructed by test_targets(), but I am not seeing COMPILER_RT_TEST_COMPILER_CFLAGS referenced in there.  This is also supported by experimentation.



https://reviews.llvm.org/D39469