[compiler-rt] r317948 - [sanitizer] Remove unnecessary attribute hidden.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 14:52:44 PST 2017


Author: eugenis
Date: Fri Nov 10 14:52:44 2017
New Revision: 317948

URL: http://llvm.org/viewvc/llvm-project?rev=317948&view=rev
Log:
[sanitizer] Remove unnecessary attribute hidden.

This should fix windows build of compiler-rt broken in r317943.

The attribute is unnecessary because since GetMaxVirtualAddress was split in two,
we no longer use common_flags() in the ifunc resolver context.

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.h

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.h?rev=317948&r1=317947&r2=317948&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.h (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.h Fri Nov 10 14:52:44 2017
@@ -34,9 +34,7 @@ struct CommonFlags {
 };
 
 // Functions to get/set global CommonFlags shared by all sanitizer runtimes:
-// FIXME: hidden needed for asan_premap_shadow. Consider building with
-// -fvisibility=hidden.
-extern CommonFlags common_flags_dont_use __attribute__((visibility("hidden")));
+extern CommonFlags common_flags_dont_use;
 inline const CommonFlags *common_flags() {
   return &common_flags_dont_use;
 }




More information about the llvm-commits mailing list