[PATCH] D39892: [llvm-cvtres] Add support for ARM64

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 13:34:32 PST 2017


mstorsjo added inline comments.


================
Comment at: lib/Object/WindowsResource.cpp:449
+  case COFF::IMAGE_FILE_MACHINE_ARM64:
+    Header->Machine = MachineType;
     break;
----------------
rnk wrote:
> I think we can sink this out, the switch is basically just a glorified assertion at this point.
So just skip the whole switch and assert altogether and just make it all a plain `Header->Machine = MachineType;`? Sounds good to me.


https://reviews.llvm.org/D39892





More information about the llvm-commits mailing list