[PATCH] D39864: Fix for CFI type tests lowering assert.

Dmitry Mikulin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 12:53:00 PST 2017


dmikulin added inline comments.


================
Comment at: llvm/lib/IR/Value.cpp:469
+      BA.push_back(std::make_pair(&U, V));
+      U.set(nullptr);
       continue;
----------------
filcab wrote:
> Does this pattern exist somewhere else in llvm?
You mean U.set(nullptr);? It's used in a few places as a way to remove a value from UseList without replacing it with anything else. There's no direct access to UseList add/remove methods. As as side effect of set(nullptr), the value ptr gets nuked, so I need to save it to restore later.


https://reviews.llvm.org/D39864





More information about the llvm-commits mailing list