[PATCH] D39464: Define fs::allocate_file which preallocates disk blocks.
Brian Cain via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 10 11:49:51 PST 2017
> -----Original Message-----
> From: Rafael Avila de Espindola [mailto:rafael.espindola at gmail.com]
...
>
> Brian Cain via Phabricator <reviews at reviews.llvm.org> writes:
>
> > bcain added a comment.
> >
> > I think it's a mistake to have the behavior be contingent on available
disk space
> for the destination partition. Has that proposal been ruled out now?
>
> Sorry, not sure what you mean. Would you mind expanding that a bit?
Sorry, I should've quoted for better context.
Rui had suggested " How about this: we can make this function to call
posix_fallocate and make FileOutputBuffer to use this function only when the
disk is almost full."
I don't think that's a good idea. I think it would represent very
surprising and mysterious behavior.
-Brian
More information about the llvm-commits
mailing list