[PATCH] D39469: [asan] Add CMake hook to override shadow scale in compiler_rt

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:51
+  # Check that the shadow scale value is valid.
+  if (NOT (COMPILER_RT_ASAN_SHADOW_SCALE GREATER -1 AND
+           COMPILER_RT_ASAN_SHADOW_SCALE LESS 8))
----------------
  if (COMPILER_RT_ASAN_SHADOW_SCALE GREATER 8 OR
           COMPILER_RT_ASAN_SHADOW_SCALE LESS 0)


================
Comment at: compiler-rt/CMakeLists.txt:58
+  set(COMPILER_RT_ASAN_SHADOW_SCALE_LLVM_FLAG
+      -mllvm -asan-mapping-scale -mllvm "${COMPILER_RT_ASAN_SHADOW_SCALE}")
+  set(COMPILER_RT_ASAN_SHADOW_SCALE_DEFINITION
----------------
I'd expect following should work: 
-mllvm -asan-mapping-scale=${COMPILER_RT_ASAN_SHADOW_SCALE}


================
Comment at: compiler-rt/lib/asan/asan_mapping.h:135
+#if defined(ASAN_SHADOW_SCALE)
+static const u64 kDefaultShadowScale = ASAN_SHADOW_SCALE;
+#else
----------------
I assume that default for your platform will be changed in separate CL?


================
Comment at: compiler-rt/test/lit.common.configured.in:28
 set_default("emulator", "@COMPILER_RT_EMULATOR@")
+set_default("asan_shadow_scale", "@COMPILER_RT_ASAN_SHADOW_SCALE@")
 set_default("ios", False)
----------------
can you just just use target_cflags and COMPILER_RT_TEST_COMPILER_CFLAGS


https://reviews.llvm.org/D39469