[PATCH] D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added inline comments.


================
Comment at: tools/llvm-cfi-verify/lib/FileAnalysis.h:51
 
+enum CFIProtectionStatus {
+  // This instruction is protected by CFI.
----------------
Lets make this an `enum class`.


================
Comment at: unittests/tools/llvm-cfi-verify/FileAnalysis.cpp:502
+  EXPECT_EQ(FAIL_NOT_INDIRECT_CF, Analysis.validateCFIProtection(Result));
+  Result = GraphBuilder::buildFlowGraph(Analysis, 0xDEADC0DE);
+  EXPECT_EQ(FAIL_UNKNOWN, Analysis.validateCFIProtection(Result));
----------------
vlad.tsyrklevich wrote:
> Could we make this an easier to differentiate constant? Took me a second to understand why this was failing on not finding the instruction
This one still looks open.


https://reviews.llvm.org/D39764