[PATCH] D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:341
+    DWARFDataExtractor LineData(*DObj, DObj->getLineSection(), isLittleEndian(),
+                                0);
+    while (Offset < LineData.getData().size()) {
----------------
JDevlieghere wrote:
> Why don't we need the address byte size here anymore? I'm super excited you got rid of the "sketchy loop" below, but I'd like to understand why we can do without it. 
Theoretically it can vary per unit.  The address size is still set below, inside the while loop, after we look up the unit associated with this part of the line-table section.


https://reviews.llvm.org/D39854