[PATCH] D39841: [CodeGenPrepare] Check that erased sunken address are not reused

[John Brawn via Phabricator via llvm-commits]

john.brawn added inline comments.


================
Comment at: test/Transforms/CodeGenPrepare/pr35209.ll:1
+; RUN: llc -start-before=codegenprepare -stop-after=codegenprepare < %s
+
----------------
Could you change this to use opt instead with explicit triple? Whether the transformation happens depends on the target's isLegalAddressingMode and llc defaults to the host target, so the test wouldn't always be testing the same thing depending on what machine you're running it on.


================
Comment at: test/Transforms/CodeGenPrepare/pr35209.ll:3-6
+; Test that if an address that was sunk from a dominating bb, used in a
+; select that is erased along with its' trivally dead operand, that the
+; sunken address is not reused if the same address computation occurs
+; after the select. Previously, this caused a ICE.
----------------
You could do with some CHECKs in this file to check that the address sinking is actually happening.


Repository:
  rL LLVM

https://reviews.llvm.org/D39841