[PATCH] D39885: Don't enable ICF by default

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

> somewhat expensive

Do you have numbers?

> hurts debuggability

According to https://msdn.microsoft.com/en-us/library/bxwfs976.aspx link.exe disables ICF by default when linking with /debug. We could do the same.

> technically non-conforming.

True, but from a practical perspective, programs that have been linked with link.exe are unlikely to break as a result of the default.

> disabling /OPT:REF by default

We might actually consider doing that in /debug builds because it should provide a better debugging experience.


https://reviews.llvm.org/D39885