[PATCH] D39873: [WebAssembly] Explicily disable comdat support for wasm output

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 9 15:47:01 PST 2017


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

I'm fine with making this explicit for now. I'm not sure I'd yet go so far as to say that the goal is not to support comdats. We should definitely investigate how C++ and its debug info are supported in mach-o, but it may be that comdats are better than whatever they do. In general in the absence of good reasons (e.g. our 2-level namespace) I'd probably have a slight bias toward doing things the ELF way rather than the macho way; most people I've talked to who've worked a lot with macho don't speak too highly of it :)


https://reviews.llvm.org/D39873





More information about the llvm-commits mailing list