[PATCH] D39814: Create a Cross-Compilation CMake toolchain file for NonWindows -> Windows

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Awesome!



================
Comment at: llvm/cmake/platforms/WinMsvc.cmake:7
+#    -DCMAKE_TOOLCHAIN_FILE=path/to/this/file
+#    -DLLVM_NATIVE_TOOLCHAIN='/path/to/llvm/installation'
+#    -DMSVC_BASE=/path/to/MSVC/system/libraries/and/includes
----------------
An even nittier nit: this line has quotes and none of the others do


================
Comment at: llvm/cmake/platforms/WinMsvc.cmake:10
+#    -DWINSDK_BASE=/path/to/windows-sdk
+#    -DWINSDK_VER=windows sdk version folder
+#
----------------
"wnindows sdk version folder **name**" might be clearer (otherwise "folder" could be the path). It's explained pretty clearly below as well though.


================
Comment at: llvm/cmake/platforms/WinMsvc.cmake:180
+# only be populated on the initial configure, and their values won't change
+# afterward. If you don't care about preserving the initial user flags, you can
+# just set CMAKE_C_FLAGS and friends directly with FORCE and skip this whole
----------------
Did you miss the comment about getting rid of the "If you don't care about preserving ..." part, or did you decide to keep it? Either way is fine; I just wanted to make sure the comment didn't go unnoticed.


https://reviews.llvm.org/D39814