[PATCH] D38619: [GVN] Prevent ScalarPRE from hoisting across instructions that don't pass control flow to successors
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 9 11:25:24 PST 2017
efriedma added inline comments.
================
Comment at: lib/Transforms/Scalar/GVN.cpp:2261
+ // was always executed. An instruction with impicit control flow could
+ // prevent us from that. If we cannot speculate the execution, then the PRE
+ // should be prohibited.
----------------
"prevent us from that" isn't correct grammar. And you misspelled "implicit".
Maybe move the comment inside the if statement?
https://reviews.llvm.org/D38619
More information about the llvm-commits
mailing list