[PATCH] D39849: [RISCV] Implement prolog and epilog insertion
Mandeep Singh Grang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 9 10:24:13 PST 2017
mgrang added inline comments.
================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:94
+
+ // Allocate space on the stack if necessary
+ if (StackSize != 0) {
----------------
nit: Period after comment.
================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:111
+
+ // Generate new FP
+ BuildMI(MBB, MBBI, DL, TII->get(RISCV::ADDI), FPReg)
----------------
nit: Period after comment.
================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:167
+ // TODO: once frame pointer elimination is implemented, don't
+ // unconditionally spill the frame pointer and return address
+ SavedRegs.set(RISCV::X1);
----------------
nit: Period after comment.
================
Comment at: lib/Target/RISCV/RISCVRegisterInfo.cpp:76
+ // pointer (positive offset), otherwise use the frame pointer (negative
+ // offset)
+ const std::vector<CalleeSavedInfo> &CSI = MFI.getCalleeSavedInfo();
----------------
nit: Period after comment.
https://reviews.llvm.org/D39849
More information about the llvm-commits
mailing list