[llvm] r317815 - revert r317812 [BasicAA] fix build break by converting the previously introduced assert into an if stmt

Nuno Lopes via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 9 09:35:36 PST 2017


Author: nlopes
Date: Thu Nov  9 09:35:36 2017
New Revision: 317815

URL: http://llvm.org/viewvc/llvm-project?rev=317815&view=rev
Log:
revert r317812 [BasicAA] fix build break by converting the previously introduced assert into an if stmt

The code has a bug, but some tests regress.
I'll discuss this further on the mailing list.

Modified:
    llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp

Modified: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp?rev=317815&r1=317814&r2=317815&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp (original)
+++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Thu Nov  9 09:35:36 2017
@@ -1289,8 +1289,7 @@ AliasResult BasicAAResult::aliasGEP(cons
   // greater, we know they do not overlap.
   if (GEP1BaseOffset != 0 && DecompGEP1.VarIndices.empty()) {
     if (GEP1BaseOffset >= 0) {
-      if (V1Size != MemoryLocation::UnknownSize &&
-          V2Size != MemoryLocation::UnknownSize) {
+      if (V2Size != MemoryLocation::UnknownSize) {
         if ((uint64_t)GEP1BaseOffset < V2Size)
           return PartialAlias;
         return NoAlias;




More information about the llvm-commits mailing list