[PATCH] D36795: [SystemZ] Increase number of LOCRs emitted by passing regalloc hints
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 9 07:04:10 PST 2017
uweigand added a comment.
See two minor inline comments. Otherwise, this now LGTM. Thanks!
================
Comment at: lib/Target/SystemZ/SystemZRegisterInfo.cpp:38
+ return &SystemZ::GR32BitRegClass;
+ if (RC == &SystemZ::GRH32BitRegClass ||
+ MO.getSubReg() == SystemZ::subreg_h32)
----------------
Should this also use hasSubClassEq, just for symmetry with the case above?
================
Comment at: lib/Target/SystemZ/SystemZRegisterInfo.cpp:103
+
+ return TargetRegisterInfo::getRegAllocationHints(VirtReg, Order, Hints, MF, VRM);
+}
----------------
Should we now pass Matrix also back to the default implementation?
https://reviews.llvm.org/D36795
More information about the llvm-commits
mailing list