[PATCH] D39464: Define fs::allocate_file which preallocates disk blocks.

Brian Cain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 19:45:56 PST 2017


bcain added a comment.

I think it's a mistake to have the behavior be contingent on available disk space for the destination partition.  Has that proposal been ruled out now?



================
Comment at: llvm/lib/Support/Unix/Path.inc:443
+  fstore_t Store = {F_ALLOCATEALL, F_PEOFPOSMODE, 0, Size};
+  if (fcntl(fd, F_PREALLOCATE, &Store) == -1)
+    return std::error_code(errno, std::generic_category());
----------------
Does this code compile with `__APPLE__`?  It looks like this typo means it won't compile.  s/fd/FD/


https://reviews.llvm.org/D39464





More information about the llvm-commits mailing list