[llvm] r317731 - [X86] Remove an if check on the result of a cast. NFC
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 8 14:26:37 PST 2017
Author: ctopper
Date: Wed Nov 8 14:26:37 2017
New Revision: 317731
URL: http://llvm.org/viewvc/llvm-project?rev=317731&view=rev
Log:
[X86] Remove an if check on the result of a cast. NFC
cast takes a non-null input and produces a non-null output. So this if can never fail.
Modified:
llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
Modified: llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp?rev=317731&r1=317730&r2=317731&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp Wed Nov 8 14:26:37 2017
@@ -2417,12 +2417,9 @@ bool X86DAGToDAGISel::matchBEXTRFromAnd(
// Update the chain.
ReplaceUses(Input.getValue(1), SDValue(NewNode, 1));
// Record the mem-refs
- LoadSDNode *LoadNode = cast<LoadSDNode>(Input);
- if (LoadNode) {
- MachineSDNode::mmo_iterator MemOp = MF->allocateMemRefsArray(1);
- MemOp[0] = LoadNode->getMemOperand();
- NewNode->setMemRefs(MemOp, MemOp + 1);
- }
+ MachineSDNode::mmo_iterator MemOp = MF->allocateMemRefsArray(1);
+ MemOp[0] = cast<LoadSDNode>(Input)->getMemOperand();
+ NewNode->setMemRefs(MemOp, MemOp + 1);
} else {
NewNode = CurDAG->getMachineNode(ROpc, dl, NVT, Input, New);
}
@@ -2706,12 +2703,9 @@ void X86DAGToDAGISel::Select(SDNode *Nod
// Update the chain.
ReplaceUses(N1.getValue(1), Chain);
// Record the mem-refs
- LoadSDNode *LoadNode = cast<LoadSDNode>(N1);
- if (LoadNode) {
- MachineSDNode::mmo_iterator MemOp = MF->allocateMemRefsArray(1);
- MemOp[0] = LoadNode->getMemOperand();
- CNode->setMemRefs(MemOp, MemOp + 1);
- }
+ MachineSDNode::mmo_iterator MemOp = MF->allocateMemRefsArray(1);
+ MemOp[0] = cast<LoadSDNode>(N1)->getMemOperand();
+ CNode->setMemRefs(MemOp, MemOp + 1);
} else {
SDValue Ops[] = { N1, InFlag };
if (Opc == X86::MULX32rr || Opc == X86::MULX64rr) {
More information about the llvm-commits
mailing list