[PATCH] D39547: [AVX512] Adding support for load truncate store of I1

Igor Breger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 05:53:01 PST 2017


igorb added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:1228
     }
+    if (Subtarget.hasDQI() && Subtarget.hasVLX() && Subtarget.hasAVX512() &&
+        Subtarget.hasBWI())
----------------
could you please explain why you set custom in case  DQI & AVX512 & VL & BWI   and not for AVX512 


================
Comment at: test/CodeGen/X86/avx512-load-trunc-store-i1.ll:4
+
+
+define void @load_v1i2_trunc_v1i1_store(<1 x i2>* %a0,<1 x i1>* %a1) {
----------------
Is it possible to create tests that test SELECT  only


https://reviews.llvm.org/D39547





More information about the llvm-commits mailing list