[PATCH] D39503: Let replaceVTableHolder accept any type

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Looks good to me, but let's wait for Adrian's approval before landing.



================
Comment at: test/DebugInfo/Generic/containing-type-extension-rust.ll:9
+; CHECK-NOT: TAG
+; CHECK: DW_AT_containing_type [DW_FORM_ref4]
+; CHECK: DW_AT_name [DW_FORM_strp] {{.*}}= "vtable")
----------------
You should also add `CHECK-NOT: TAG` below this line if the DW_AT_name should belong to the same DW_TAG_structure_type


================
Comment at: test/DebugInfo/Generic/containing-type-extension.ll:9
+; CHECK-NOT: TAG
+; CHECK: DW_AT_containing_type [DW_FORM_ref4]
+; CHECK: DW_AT_name [DW_FORM_strp] {{.*}}= "vtable")
----------------
Same here.


https://reviews.llvm.org/D39503