[PATCH] D39780: Remove unused condition.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 20:20:53 PST 2017


ruiu created this revision.
Herald added subscribers: arichardson, emaste.

Looks like all tests pass without this `isLocal()`.


https://reviews.llvm.org/D39780

Files:
  lld/ELF/Symbols.cpp


Index: lld/ELF/Symbols.cpp
===================================================================
--- lld/ELF/Symbols.cpp
+++ lld/ELF/Symbols.cpp
@@ -120,7 +120,7 @@
 // Returns true if this is a weak undefined symbol.
 bool Symbol::isUndefWeak() const {
   // See comment on Lazy in Symbols.h for the details.
-  return !isLocal() && isWeak() && (isUndefined() || isLazy());
+  return isWeak() && (isUndefined() || isLazy());
 }
 
 InputFile *Symbol::getFile() const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39780.122028.patch
Type: text/x-patch
Size: 467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171108/6319d404/attachment.bin>


More information about the llvm-commits mailing list