[PATCH] D39670: [AMDGPU] Fix pointer info for pseudo source for r600

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 18:58:45 PST 2017


yaxunl added a comment.

In https://reviews.llvm.org/D39670#918112, @tstellar wrote:

> r600 doesn't support generic address space, so in that case, I would recommend only defining an intrinsic to be used by amdgcn.  I understand the problem with non-constant address spaces, but I think the best solution here would be to try to make more of a separation between the amdgcn code and the r600 code in the backend rather than trying to change the address space mapping for r600.  r600 should really be mostly read-only at this point.


We discussed this internally and concluded that having a static address space mapping is more important. Most of issues are due to using dummy pointer info. Such places should be few in r600 code, therefore we will continue fixing these issues unless we found there need excessive efforts to do so.


https://reviews.llvm.org/D39670





More information about the llvm-commits mailing list