[PATCH] D39743: [ValueLattice] Use PointerIntPair (WIP).

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Structural suggestion: pick either of the two subtasks and implement them in isolation.  That is *either* replace the ConstantRange with an owned ConstantRange allocation and implement the tagged pointer OR implement the ConstantRange folding set.  Doing both in one change is needlessly complicated.  Once one is done, the other follows more naturally.  I'd suggest the first then the second, but either order is defensible.

Can I ask why you chose to tackle this one?  What motivated you to care about the memory consumption of LVI?  Just curious about the background and motivating test cases.


https://reviews.llvm.org/D39743