[llvm] r317626 - Fix build bots after r317622

Dave Lee via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 15:04:54 PST 2017


Ah got it. Thanks for catching this.

On Tue, Nov 7, 2017 at 3:01 PM, Davide Italiano <davide at freebsd.org> wrote:

> On Tue, Nov 7, 2017 at 2:37 PM, Craig Topper via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > This wil always return 0 in a release build. Is that what you want? Or
> > should it be calling lookup in release builds?
> >
>
> This is definitely not right. The right fix here is to hoist the
> lookup function outside of the assertion to make sure it
> doesn't get stripped in builds without assertions.
> Thanks for reverting.
>
> --
> Davide
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171107/818e3105/attachment.html>


More information about the llvm-commits mailing list