[PATCH] D39761: [Support] Make llvm::Error faster

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 14:44:51 PST 2017


lhames added a comment.

Nice!

Aside: getChecked() should be a no-op in release builds, but we do still check the error pointer for equivalence with uncaught exceptions. (I'm open to revisiting that idea: we also have better error checking validation than exceptions provide).

So does the 15% speed-up mean that you're now spending ~0% in Error destructors?


https://reviews.llvm.org/D39761





More information about the llvm-commits mailing list