[PATCH] D39710: Simplify unlinkAsync

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Filesystem.cpp:19
 #include "llvm/Support/FileSystem.h"
+#include <unistd.h>
 
----------------
Does all system have unistd.h?


================
Comment at: ELF/Filesystem.cpp:54
 
-  // Remove TempPath in background.
-  runBackground([=] { ::remove(TempPath.str().str().c_str()); });
+  sys::fs::remove(Path);
+
----------------
Is this safe on Windows? On Windows, you can't remove opened files.


https://reviews.llvm.org/D39710