[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks for converting the other testcase.

> I left the existing test (dwarfdump-header.s) as a checked-in binary, because it tests both normal and split headers, and I don't know what MachO section names to use for the .dwo sections.

There is no need to test split DWARF + MachO since that combination is neither tested nor specified anywhere.

Why can't the other test be ELF-only assembler though? Otherwise this LGTM now.



================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-header-64.s:18
+ at ELF@   .section .debug_str,"MS", at progbits,1
+ at MACHO@ .section __DWARF,__debug_str,regular,debug
+str_producer:
----------------
Nice, thank you!


https://reviews.llvm.org/D33155