[PATCH] D39670: [AMDGPU] Fix pointer info for pseudo source for r600

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added a comment.

In https://reviews.llvm.org/D39670#918093, @yaxunl wrote:

> In https://reviews.llvm.org/D39670#918042, @tstellar wrote:
>
> > Which intrinsic functions are you refering to?  To me it seems easier to not touch r600 at all, but I guess I'm not as deep into the code as you.  Can you give me some specific examples for how adding support to r600 for this alternative mapping simplifies the backend?
>
>
> For example, if we want to define a intrinsic function returning generic pointer, we have to define two versions. one for amdgiz environment, one for other environment, because they have different address space value for generic pointer. And we have to let the backend choose which version based on target environment.
>
> Also, because address space values depends on target triple, we can not define them as constants. Instead it has to be a structure returned by function getAMDGPUAS(triple) and use it. If we only supports one address space mapping, we can define it as an enum and use it.


Sorry I forgot to mention: the plan is to let amdgcn and r600 only support the new address space mapping, then make it default and remove the old address space mapping.


https://reviews.llvm.org/D39670