[PATCH] D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

This seems fine as far as avoiding the warnings themselves go, but I'm not familiar enough with install_name and rpath on macOS to know if the new policy behavior is doing the right thing.

Looking at the list in https://cmake.org/cmake/help/v3.9/policy/CMP0068.html, the only affected property that's used by LLVM is `BUILD_WITH_INSTALL_RPATH`. The documentation suggests that `BUILD_WITH_INSTALL_NAME_DIR` should be set in addition to `BUILD_WITH_INSTALL_RPATH` to simulate the OLD behavior of CMP0068, which seems to be the safer route. Again, I'm not sure how important the old behavior is though; @beanz is the right person for that.


https://reviews.llvm.org/D39716