[PATCH] D39732: [Analysis] Fix merging TBAA tags with different final access types
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 7 08:36:46 PST 2017
hfinkel added inline comments.
================
Comment at: lib/Analysis/TypeBasedAliasAnalysis.cpp:545
TBAAStructTagNode TagA(A), TagB(B);
+ const MDNode *CommonType = getLeastCommonType(TagA.getAccessType(),
+ TagB.getAccessType());
----------------
Can you please *explain* the problem in the patch description.
Also, we're now creating new metadata nodes speculatively (i.e., in cases where we we'll return false); can we avoid doing that? (maybe using a lambda function would help?)
Repository:
rL LLVM
https://reviews.llvm.org/D39732
More information about the llvm-commits
mailing list