[PATCH] D36742: [LLD][ELF][AArch64] Implement scanner for Cortex-A53 Erratum 843419

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 06:46:19 PST 2017


peter.smith updated this revision to Diff 121890.
peter.smith added a comment.

Thanks very much for the comments. I've made the following changes:

- Changed the name of the files from SectionPatcher to AArch64ErrataFix. The technique for fixing errata isn't unique to AArch64, it has been applied to Arm before in other linkers, but I guess we can rename the file later if it becomes more generic.
- Removed the A64 struct.
- Got rid of GetInstr and simplified a bit.
- Created a function to remove some of the indentation.

Unfortunately mapping symbols aren't guaranteed to be ordered. It was thought too target specific to mandate in the ABI.


https://reviews.llvm.org/D36742

Files:
  ELF/AArch64ErrataFix.cpp
  ELF/AArch64ErrataFix.h
  ELF/CMakeLists.txt
  ELF/Config.h
  ELF/Driver.cpp
  ELF/Options.td
  ELF/Writer.cpp
  test/ELF/aarch64-cortex-a53-843419-address.s
  test/ELF/aarch64-cortex-a53-843419-cli.s
  test/ELF/aarch64-cortex-a53-843419-nopatch.s
  test/ELF/aarch64-cortex-a53-843419-recognize.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36742.121890.patch
Type: text/x-patch
Size: 49908 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171107/9bcc3819/attachment.bin>


More information about the llvm-commits mailing list