[PATCH] D39346: [LV] [ScalarEvolution] Fix PR34965 - Cache pointer stride information before LV code gen

[Renato Golin via Phabricator via llvm-commits]

rengolin added reviewers: gilr, Ayal, hsaito.
rengolin added a comment.

In https://reviews.llvm.org/D39346#915527, @dcaballe wrote:

> I implemented a new fix where the return value of Legal->isConsecutivePtr() is collected just before the original loop is modified. This approach seems simpler and less invasive than the one described in my previous comment.


I may not have understood the problem correctly, but I think we shouldn't moved cached analysis into new representations.

To me it seems that SCEV is not able to see something that has a dependency, which VPlan has just exposed. In this case, fixing/extending SCEV is the right thing to do.

I'm adding the VPlan folks to get a wider audience.

cheers,
--renato


https://reviews.llvm.org/D39346