[PATCH] D39606: [SLP] Fix PR23510: Try to find best possible vectorizable stores.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of minors



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4318
+  SetVector<StoreInst *> Heads;
+  SmallDenseSet<StoreInst *>Tails;
   SmallDenseMap<StoreInst *, StoreInst *> ConsecutiveChain;
----------------
Space between > and Tails


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4334
     // If a store has multiple consecutive store candidates, search Stores
-    // array according to the sequence: from i+1 to e, then from i-1 to 0.
+    // array according to the sequence: Idx-1, Idx+1, Idx-2, Idx+2, ...
     // This is because usually pairing with immediate succeeding or preceding
----------------
> Idx-1, Idx+1, Idx-2, Idx+2, ...

Idx+2 ? Fix this sequence




https://reviews.llvm.org/D39606