[PATCH] D38635: Add 'first link flags' for building tests

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added a comment.

Are the changes that actually use this feature going to be upstreamed as well? Or are they specific to an internal build? It's never great to introduce seemingly dead or unused code.



================
Comment at: libcxx/utils/libcxx/compiler.py:32
         self.link_flags = list(link_flags or [])
+        self.first_link_flags = []
         self.warning_flags = list(warning_flags or [])
----------------
If we just need this to pass object files to the link, then I think making it specific to that purpose might be better. IE `link_objects` instead of `first_link_flags`.


Repository:
  rL LLVM

https://reviews.llvm.org/D38635