[PATCH] D39393: [asan] Use dynamic shadow on 32-bit Android.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:970
 
-uptr GetMaxVirtualAddress() {
+uptr GetMaxVirtualAddress(bool ifunc_safe) {
 #if SANITIZER_NETBSD && defined(__x86_64__)
----------------
pcc wrote:
> Is the `ifunc_safe` change necessary? If `common_flags()` is inlined, I would expect the access to go through `common_flags_dont_use`, which you have marked as hidden. You might want to make `common_flags()` hidden as well, in case it doesn't get inlined.
unfortunately it does into GetKernelAreaSize(), because common_flags()->full_address_space is statically initialized to false. And that is not ifunc-safe.


https://reviews.llvm.org/D39393