[PATCH] D39669: DAG: Preserve nuw when reassociating adds
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 6 15:22:47 PST 2017
arsenm added a comment.
In https://reviews.llvm.org/D39669#916977, @aprantl wrote:
> If it does break a subsequent commit, could you commit that first, and then apply this to fix the regressions introduced by the other commit?
This would be the 3rd time I've had to touch all of the tests impacted by the, and each time it's been a pain. That patch adds folding an addressing mode that doesn't support overflows, so directly checks NUW. Once that's in it should be more straightforward to write the tests with these situations directly feeding into the address expression.
https://reviews.llvm.org/D39669
More information about the llvm-commits
mailing list