[PATCH] D39628: [DebugInfo] Unify logic to merge DILocations. NFC.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 11:10:06 PST 2017


vsk added a comment.

In https://reviews.llvm.org/D39628#916956, @aprantl wrote:

> What about the common-parent-scope-finding logic?


Prior to this patch, the common-parent-scope finding logic could only kick in if `this` is-a CallInst. That behavior is preserved: DILocation::getMergedLocation() only finds a common parent scope when `ForInst` is-a CallInst.


https://reviews.llvm.org/D39628





More information about the llvm-commits mailing list