[PATCH] D39628: [DebugInfo] Unify logic to merge DILocations. NFC.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D39628#915861, @aprantl wrote:

> It looks like this will cause DILocation::getMergedLocation() to create new DILocations? When this happens at the MIR level this will cause problems with the textual MIR output because the new locations aren't printed. Should we introduce a flag to disable creation of new metadata?


getMergedLocation() shouldn't be able to create a new DILocation unless `ForInst` is-a CallInst, which shouldn't happen at the MIR level. If we added a flag to explicitly disable creation of new metadata, it would be 'true' iff ForInst is not a CallInst. Can I instead add more documentation for the ForInst parameter?


https://reviews.llvm.org/D39628